Wow  !! you have exceled Tim, I really appreciate the time and effort you have put in to explain things, and this will definately help me and others I am sure, to work through some practical Bullscript. I'll study this and no doubt will gain some useful knowledge for future reference. 

cheers etrader.

{RSI(9) DIVERGENCE BUY:}
If(RSI(9) >= HHV(RSI(9),19) AND CLOSE <HHV(CLOSE,19), 1, 0) 
OR 
If(CLOSE <= LLV(CLOSE,19) AND RSI(9) > LLV(RSI(9),19), 1, 0);

{RSI(9) DIVERGENCE SELL:}
If(CLOSE >= HHV(CLOSE,19) AND RSI(9)<HHV(RSI(9),19), 1, 0)
OR
If(RSI(9) <= LLV(RSI(9),19) AND CLOSE > LLV(CLOSE,19), 1, 0);

Originally posted by etrader I tried this also below which returned no errors, but not sure what the 0 is at the end. I would have expected maybe more returns ?? {RSI(9) DIVERGENCE BUY:} IF (rsi(close,9) >= HHV(RSI(close,9),19) AND CLOSE < HHV(CLOSE,19),1,0) OR IF (CLOSE <= LLV(CLOSE,19) AND RSI(9) > LLV(RSI(close,9),19), 1,0);

That's the same as the first half of what I got, so you're doing alright there. However, when I add that indicator to a chart of, say, BHP or TLS, I get a steady, unwavering line at 0, indicating that this particular signal never went off.

When I look at a big, complicated expression like this, I can't imagine how it works all in my head at the same time, so I'm going to break it up into smaller components and see how those work.

• I'm going to delete the SELL half of the indicator to simplify things, because it's basically just the inverse of the BUY half - whatever makes the BUY half work should make the SELL half work as well.
• I'm going to comment-out the BUY half, because I know it always returns 0, so it'll just get in the way. I won't delete it because I want to copy-and-paste things from it.
• When I look at the BUY indicator, the first thing I notice is that it's got two conditions, linked by an OR: "cond1 OR cond2". So it would be a good idea to investigate each of these conditions separately before putting them together.
• The first condition is silly, since it looks like this: "if(cond3, 1, 0)". Basically, if cond3 is true, the if() function returns true. If cond3 is false, the if() function returns false. Therefore "if(cond3, 1, 0)" is exactly equivalent to "(cond3)". So let's look at cond3.
• cond3 contains two expressions, linked with an AND: "RSI(9) >= HHV(RSI(9),19) AND CLOSE <HHV(CLOSE,19)". Let's look at both halves of the indicator individually, and see what happens.

{RSI(9) DIVERGENCE BUY:}
{
If(RSI(9) >= HHV(RSI(9),19) AND CLOSE <HHV(CLOSE,19),1,0) 
OR 
If(CLOSE <= LLV(CLOSE,19) AND RSI(9) > LLV(RSI(9),19),1,0);
}

RSI(9) >= HHV(RSI(9),19);
CLOSE < HHV(CLOSE,19);

[color=red]
RSI(9) >= HHV(RSI(9),19);
[color=blue]
CLOSE < HHV(CLOSE,19);

[color=red]
RSI(CLOSE, 9) >= HHV(RSI(CLOSE, 9),19);
[color=blue]
CLOSE < HHV(CLOSE,19);

RSI(CLOSE, 9) >= HHV(RSI(CLOSE, 9),19) AND CLOSE < HHV(CLOSE,19);

{RSI(9) DIVERGENCE BUY:}
(RSI(CLOSE, 9) >= HHV(RSI(CLOSE, 9), 19) AND CLOSE < HHV(CLOSE, 19)) 
OR 
(CLOSE <= LLV(CLOSE, 19) AND RSI(CLOSE, 9) > LLV(RSI(CLOSE, 9), 19));

{RSI(9) DIVERGENCE SELL:}
(CLOSE >= HHV(CLOSE, 19) AND RSI(CLOSE, 9) < HHV(RSI(CLOSE, 9), 19))
OR
(RSI(CLOSE, 9) <= LLV(RSI(CLOSE, 9), 19) AND CLOSE > LLV(CLOSE, 19));

[target=Price]

{RSI(9) DIVERGENCE BUY:}
[name=Type1; linestyle=marker; marker=type1; tooltip="Decide for yourself what you should do in this situation"]
(RSI(CLOSE, 9) >= HHV(RSI(CLOSE, 9), 19) AND CLOSE < HHV(CLOSE, 19)) 
OR 
(CLOSE <= LLV(CLOSE, 19) AND RSI(CLOSE, 9) > LLV(RSI(CLOSE, 9), 19));

{RSI(9) DIVERGENCE SELL:}
[name=Type2; linestyle=marker; marker=type2; tooltip="Decide for yourself what you should do in this situation"]
(CLOSE >= HHV(CLOSE, 19) AND RSI(CLOSE, 9) < HHV(RSI(CLOSE, 9), 19))
OR
(RSI(CLOSE, 9) <= LLV(RSI(CLOSE, 9), 19) AND CLOSE > LLV(CLOSE, 19));

I did try and copy and paste but got this error initially.

I am not a programmer so am trying to understand the IF's and buts. I tried this also below which returned no errors, but not sure what the 0 is at the end. I would have expected maybe more returns ??

I understand what divergence is, and that we are looking for a higher RSI value after 19 bars and a lower close after 19 bars [and the opposite for the LLV], but the problem I have is my programming iliteracy I guess, and how to make this totally effective with markers etc.

IF (rsi(close,9) >= HHV(RSI(close,9),19) AND CLOSE < HHV(CLOSE,19),1,0) OR

IF (CLOSE <= LLV(CLOSE,19) AND RSI(9) > LLV(RSI(close,9),19), 1,0);

I would appreciate if you could help with this conversion from Metastock to bullscript Tim. I thought i could work it out, but got stuck.

RSI Divergence

{RSI(9) DIVERGENCE BUY:}
If(RSI(9) >= HHV(RSI(9),19) AND CLOSE <HHV(CLOSE,19), 1,0) OR
If(CLOSE <= LLV(CLOSE,19) AND RSI(9) > LLV(RSI(9),19), 1,0)

{RSI(9) DIVERGENCE SELL:}
If(CLOSE >= HHV(CLOSE,19) AND RSI(9)<HHV(RSI(9),19),1,0) OR
If(RSI(9) <= LLV(RSI(9),19) AND CLOSE > LLV(CLOSE,19),1,0)

{You can substitute any formula for the "RSI(9)"}

cheers etrader